Repository navigation
OpenGP 1.0.2: fixes, menu wording and a first-run hint - #3
Merged
Merged
Conversation
Next to OpenGP in a package, "opengp-install" read as the program to run first to install OpenGP, but players open OpenGP; the other is the command-line builder. The CMake target and library keep their names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The path showed the player's user name on screen and in screenshots. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
For gamepads without a Guide button, or where Steam or the system takes it. Back is the coin and Start is start by default, so the first of the two is held back from the game for 120 ms: if the other follows, the game sees neither; a quicker tap is replayed, so no coin is lost. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
controls.toml keeps naming keys by their place on a US keyboard, so it works with any layout; the menu now shows them as the layout prints them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
On Windows and X11 SDL's window sizes are pixels, so the default 1280 x 720 window was tiny on a 4K display at 200%. settings.toml now keeps the size at 100% scale; a new window is scaled for its display (no larger than it) and centred. macOS and Wayland already scaled it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A player's console showed the SDK's start-up banners (OSReport), hardware register and unhandled accesses, the DSP's microcode and a status line every 5 seconds: a race printed about 130 lines. Without --verbose it now shows the start-up summary, what happens and problems (9 lines). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Once, when the game has started (about 10 seconds in), a notice says which keys put in a coin and start (by the player's bindings, and the gamepad's buttons when they are the defaults) and how to open the menu. settings.toml's first_run_hint turns it off after. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
macOS 26 deprecates posix_spawn_file_actions_addchdir_np, but the packages run on macOS 13 and later, which have only that name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
They went to the game as 8-bit values (256 steps), but the cabinet's analog inputs are 16-bit and the game uses about 41,000 steps of steering: a wheel or pedal with 10 bits or more lost most of its resolution. triforce::Controls now carries them as floats; scripts keep 0-255. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Until a device sends its first report SDL reads every axis as 0, the middle of its travel. A pedal resting at one end therefore read half pressed until it was first moved, and binding it from the menu took that first report for a press of the wrong half (axis1+ for a pedal that rests at the top). An axis now counts only once it has reported (SDL_GetJoystickAxisInitialState), and a capture takes its first report as where it rests. Tested with an SDL virtual joystick. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The game's start-up check asks the camera for one picture (measured: one request about 15 s in; the photo screen asks about 10 times a second for 11 s). It always got a grey one, since a webcam takes longer to start, but it switched the webcam on for nothing: the first request of a run now gets grey without it. A webcam's first frames are dark while its exposure settles. Warmup (camera/warmup.h) holds them back until the brightness is steady for 3 frames and at least 250 ms have passed, or 2 s whatever happens, so a dark frame can't become a player's photo. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
When the device stalls (as while the system switches to another one) the queue fills to its limit, and the controller, at most 0.5% faster, took about 20 seconds to work it off: the sound ran up to 150 ms late. When the queue stays far above its target, new samples are now dropped until it is back (one short skip). The target was a fixed 30 ms whatever the device. It is now twice the device's buffer (at least 30 ms), looked at again every second, and grows 10 ms each time the queue runs dry, up to 80 ms. The status line shows the target and resyncs. test_audio checks the catch-up on SDL's dummy driver. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Tested with a Nintendo Switch Camera in a dim room: its picture had a mean brightness of about 2 out of 255 (ffmpeg's capture agrees, 4), so the photo was almost black. The cabinet's camera had its own light. AutoGain now brings a dark picture towards a normal brightness, at most 6 times, changing gradually so it doesn't flicker. Opening that webcam took long enough that the warm-up's 250 ms had passed before the first frame: it is now counted from the first frame. Warmup and AutoGain are in camera/exposure.h (was warmup.h). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Opening the menu clears information notices (the hint: the player has found the menu); problems stay up. The hint waits while the menu is open. Found by the macOS on-screen check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The game's retraces come at NTSC's 59.94 Hz (40.5 MHz / 1,351,350 ticks a frame), 0.1% slower than a 60 Hz display, so with vsync one display frame in a thousand repeated the previous game frame: a small hitch every 16.7 seconds, and the same on 120 Hz. Hardware gets a clock rate: from an anchor (no jump), the time base runs at that rate against the host's clock, read without a lock (a seqlock), and timebase_at/steady_ns_at follow it. With vsync on, on a display within 0.5% of a multiple of 59.94 Hz, the launcher sets it to match (1.001001 at 60 Hz; measured: 1200 retraces every 20 s instead of 1198.8). Variable refresh, other rates, no vsync and linked races stay at real time; the sound's controller absorbs the 0.1%. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
1.0.2 links with 1.0.1 (the link's version stays 2). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Pause, Discord, Controls, Camera and Link rows get shorter names and clearer help text - Aspect ratio and resolution options name their sizes (4:3, 16:9, 720p, 1080p, 4K and so on) - Camera choices are Disabled, Enabled and Colour bars (test) - Link: "Link using LAN" replaces "Link over the local network" - Background input replaces the conditional background-controls help text
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Release 1.0.2 (
CMakeLists.txtandCHANGELOG.md). The changes, from the changelog:opengp-cli, so it isn't mistaken for the way to install OpenGP. Docs and the package's README are updated to match.--verbose.How it was tested
tests/test_audio.cpp,tests/test_camera.cpp,tests/test_controls.cpp,tests/test_input.cpp,tests/test_pause.cpp).ctestandtools/check_game_data.py.Checklist
python3 tools/check_game_data.pypasses).// SPDX-License-Identifier: GPL-3.0-or-later; ported Dolphin code says so.ctestpasses.